[Forwardport] Refactor: remove some code duplication#17571
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Aug 16, 2018
arnoudhgz:2.3-develop-PR-port-17505
Merged
[Forwardport] Refactor: remove some code duplication#17571magento-engcom-team merged 1 commit intomagento:2.3-developfrom arnoudhgz:2.3-develop-PR-port-17505
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
arnoudhgz:2.3-develop-PR-port-17505
Conversation
+ Complex statement that was executed three times moved to separate method so the logic is only on one place + The calculation for the index of the last record moved to a variable so the calculation is only being done once. This also reduces the amount of times `this.getChildItems()` is being called.
magento-engcom-team
added
Partner: MediaCT
Contributor
|
Hi @arnoudhgz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
|
Hi @arnoudhgz. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17505
method so the logic is only on one place
so the calculation is only being done once. This also reduces the amount
of times
this.getChildItems()is being called.Contribution checklist